-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Add Stock Items
index component
#5532
Merged
rainerdema
merged 4 commits into
solidusio:main
from
nebulab:rainerd/admin/add-stock-items-index-page
Dec 5, 2023
Merged
[Admin] Add Stock Items
index component
#5532
rainerdema
merged 4 commits into
solidusio:main
from
nebulab:rainerd/admin/add-stock-items-index-page
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
force-pushed
the
rainerd/admin/add-stock-items-index-page
branch
3 times, most recently
from
December 4, 2023 12:42
088c895
to
9be95dc
Compare
github-actions
bot
added
the
changelog:solidus_core
Changes to the solidus_core gem
label
Dec 4, 2023
rainerdema
force-pushed
the
rainerd/admin/add-stock-items-index-page
branch
3 times, most recently
from
December 4, 2023 15:35
201c3bd
to
a8d4f56
Compare
Enhanced the search capabilities in the admin panel by updating the `allowed_ransackable_associations` of the `Spree::StockItem` model. This update specifically adds the `variant` association to the list of associations that can be searched using Ransack.
rainerdema
force-pushed
the
rainerd/admin/add-stock-items-index-page
branch
2 times, most recently
from
December 4, 2023 16:55
a3f40d7
to
3aa11a2
Compare
elia
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a suggestion for improving the readability for the search focus
admin/app/components/solidus_admin/stock_items/index/component.rb
Outdated
Show resolved
Hide resolved
@@ -47,7 +47,6 @@ def filters | |||
] | |||
end | |||
}, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
rainerdema
force-pushed
the
rainerd/admin/add-stock-items-index-page
branch
from
December 5, 2023 10:26
3aa11a2
to
349502f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: