Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add Stock Items index component #5532

Merged

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Dec 1, 2023

Summary

Screenshot 2023-12-04 at 17 51 47 Screenshot 2023-12-04 at 17 51 51 Screenshot 2023-12-04 at 17 52 02 Screenshot 2023-12-04 at 17 52 18 Screenshot 2023-12-04 at 17 52 28

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema self-assigned this Dec 1, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/add-stock-items-index-page branch 3 times, most recently from 088c895 to 9be95dc Compare December 4, 2023 12:42
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 4, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/add-stock-items-index-page branch 3 times, most recently from 201c3bd to a8d4f56 Compare December 4, 2023 15:35
Enhanced the search capabilities in the admin panel by updating
the `allowed_ransackable_associations` of the `Spree::StockItem` 
model.

This update specifically adds the `variant` association to the
list of associations that can be searched using Ransack.
@rainerdema rainerdema force-pushed the rainerd/admin/add-stock-items-index-page branch 2 times, most recently from a3f40d7 to 3aa11a2 Compare December 4, 2023 16:55
@rainerdema rainerdema marked this pull request as ready for review December 4, 2023 16:56
@rainerdema rainerdema requested a review from a team as a code owner December 4, 2023 16:56
@rainerdema rainerdema requested a review from elia December 4, 2023 16:56
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a suggestion for improving the readability for the search focus

admin/app/components/solidus_admin/ui/table/component.js Outdated Show resolved Hide resolved
@@ -47,7 +47,6 @@ def filters
]
end
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@rainerdema rainerdema force-pushed the rainerd/admin/add-stock-items-index-page branch from 3aa11a2 to 349502f Compare December 5, 2023 10:26
@rainerdema rainerdema merged commit 946a49e into solidusio:main Dec 5, 2023
8 checks passed
@rainerdema rainerdema deleted the rainerd/admin/add-stock-items-index-page branch December 5, 2023 10:37
@elia elia removed the changelog:solidus_core Changes to the solidus_core gem label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants